On Sat, 25 Apr 2020 at 11:48, Heinrich Schuchardt <xypron.glpk@xxxxxx> wrote: > > On 4/21/20 9:19 PM, Palmer Dabbelt wrote: > > On Mon, 13 Apr 2020 14:29:03 PDT (-0700), Atish Patra wrote: > >> Most of the arm-stub code is written in an architecture independent > >> manner. > >> As a result, RISC-V can reuse most of the arm-stub code. > >> > >> Rename the arm-stub.c to efi-stub.c so that ARM, ARM64 and RISC-V can > >> use it. > >> This patch doesn't introduce any functional changes. > >> > >> Signed-off-by: Atish Patra <atish.patra@xxxxxxx> > > The code being moved has some problems: > > The ARM stub ignores the return value of efi_setup_gop(). > > drivers/firmware/efi/libstub/arm-stub.c and > drivers/firmware/efi/libstub/x86-stub.c both call LocateHandle() before > calling efi_setup_gop(). I think this should be moved to efi_setup_gop(). > > I guess the issues can be addressed in some follow up patch. > Yes, I suppose this could be improved a bit, so patches welcome, as usual :-) But I don't think it has any bearing on a patch that renames the file.
