On Thu, 16 Apr 2020 at 21:07, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote: > > On Thu, Apr 16, 2020 at 06:48:30PM +0200, Ard Biesheuvel wrote: > > The practice of using __pure getter functions to access global > > variables in the EFI stub dates back to the time when we had to > > carefully prevent GOT entries from being emitted, because we > > could not rely on the toolchain to do this for us. > > > > Today, we use the hidden visibility pragma for all EFI stub source > > files, which now all live in the same subdirectory, and we apply a > > sanity check on the objects, so we can get rid of these getter > > functions and simply refer to global data objects directly. > > > > Start with efi_system_table(), and convert it into a global variable. > > > > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > > Could turn efi_is_64bit() into an inline function as well? Yep
