On Thu, Mar 19, 2020 at 01:53:38AM -0700, Zhuo, Qiuxu wrote: > > From: linux-efi-owner@xxxxxxxxxxxxxxx <linux-efi-owner@xxxxxxxxxxxxxxx> On> Behalf Of Ard Biesheuvel > > ... > > > The following commit on the tip tree removes the variables 'config_table' from the efi structure. > > > > > > 9cd437ac0ef4 ("efi/x86: Make fw_vendor, config_table and runtime sysfs nodes x86 specific") > > > > > > But the external driver "capsule-pstore.ko" needs to access 'config_table' and 'nr_tables' to go through the configuration table to extract crash capsules. > > > > > > Adding 'config_table' and 'nr_tables' back to the efi structure looks like not a good way. > > > Do you have any suggestion on how to export 'config_table' and 'nr_tables' variables for the external driver "capsule-pstore.ko"? > > > > > > > I will get back to you on monday about this. In any case, this will have to wait until v5.8 > > OK. Thanks! Would it be acceptable to take the first half of Qiuxu's function efi_capsule_table_get() and move it into the generic efi code naming it something like: "efi_get_table_by_guid()"? Then EXPORT_GPL that function? -Tony