On Thu, Mar 12, 2020 at 6:46 PM Borislav Petkov <bp@xxxxxxxxx> wrote: > How do you know *everyone* affected will update their BIOS? > > And what's the downside of keeping it? It could indeed be kept without user-visible downside, and that would be the normal case for quirks that work around BIOS bugs. But I had two reasons for suggesting that Jian-Hong should send this revert patch, which may be worth some consideration: 1. This was working around a BIOS bug truly separate from Linux to the point where it was a little questionable for Linux to put a quirk in place. The original bug was that after Linux completed executing the reboot code, the machine would reboot, the BIOS would start loading, and then crash well before loading the OS. Presumably crashing on some state that Linux left that was not reset in the machine's reboot stage. The vendor later found the issue (something TPM-related) and fixed the BIOS to avoid the crash. 2. We normally receive these units before they go into mass production, so there's a decent chance that production versions already include this BIOS fix. Based on that I was considering that the patch could be reverted for cleanliness/ At the same time, I do not have strong feelings on this, no issues if the quirk is left in place. Daniel
