On Wed, 4 Mar 2020 at 16:45, Vladis Dronov <vdronov@xxxxxxxxxx> wrote: > > Hello, Ard, > > > Wouldn't it be easier to pass a var_data_size stack variable into > > efivar_entry_get(), and only update the value in 'var' if it is <= > > 1024? > > I have prepared a v2 patch with an approach you suggest and will send it > out shortly. It indeed simpler and fixes only the overflow bug mentioned. > > Could you, please, review it and if you like it, probably, accept it? > In case I've implemented your idea incorrectly, could you, please, > correct me? > Absolutely! Thanks for taking the time to fix these bugs, your contributions are most welcome (and apologies if my responses suggested otherwise)