On Mon, Feb 24, 2020 at 01:38:39PM +0200, Nikolai Merinov wrote: > Hi Christoph, > > > I'd rather use plain __le16 and le16_to_cpu here. Also the be > > variants seems to be entirely unused. > > Looks like I misunderstood your comment from https://patchwork.kernel.org/patch/11309223/: > > > Please add a an efi_char_from_cpu or similarly named helper > > to encapsulate this logic. > > The "le16_to_cpu(ptes[i].partition_name[label_count])" call is the > full implementation of the "efi_char_from_cpu" logic. Do you want > to encapsulate "utf16_le_to_7bit_string" logic entirely like in > the attached version? I think I though of just the inner loop, but your new version looks even better, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
