On Thu, Feb 06, 2020 at 02:03:51PM +0000, Ard Biesheuvel wrote:
> --- a/drivers/firmware/efi/libstub/efistub.h
> +++ b/drivers/firmware/efi/libstub/efistub.h
> @@ -566,6 +566,14 @@ union efi_load_file_protocol {
> } mixed_mode;
> };
>
> +struct efi_vendor_dev_path {
> + u8 type;
> + u8 sub_type;
> + u16 length;
> + efi_guid_t vendorguid;
> + u8 vendordata[];
> +} __packed;
In commit 46cd4b75cd0e ("efi: Add device path parser") I introduced a
struct efi_dev_path with a union for the type-specific data. Maybe
you can make use of it instead of introducing a new type?
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -323,3 +323,68 @@ void efi_char16_printk(efi_char16_t *str)
> efi_call_proto(efi_table_attr(efi_system_table(), con_out),
> output_string, str);
> }
> +
> +static const struct {
> + struct efi_vendor_dev_path vendor;
> + struct efi_generic_dev_path end;
> +} __packed initrd_devpath = {
Nit: Can we consistently stick to "dev_path" in lieu of "devpath"?
Thanks,
Lukas
