On Thu, 9 Jan 2020 at 03:23, Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > On Wed, Dec 25, 2019 at 6:46 AM kbuild test robot <lkp@xxxxxxxxx> wrote: > > > > Hi Saravana, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on efi/next] > > [cannot apply to rockchip/for-next keystone/next arm64/for-next/core arm-soc/for-next shawnguo/for-next clk/clk-next arm/for-next linux-rpi/for-rpi-next at91/at91-next v5.5-rc3 next-20191220] > > [if your patch is applied to the wrong git tree, please drop us a note to help > > improve the system. BTW, we also suggest to use '--base' option to specify the > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > > > url: https://github.com/0day-ci/linux/commits/Saravana-Kannan/efi-arm-defer-probe-of-PCIe-backed-efifb-on-DT-systems/20191225-182253 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next > > config: arm64-alldefconfig (attached as .config) > > compiler: aarch64-linux-gcc (GCC) 7.5.0 > > reproduce: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > GCC_VERSION=7.5.0 make.cross ARCH=arm64 > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > > > All errors (new ones prefixed by >>): > > > > drivers/firmware/efi/arm-init.o: In function `efifb_add_links': > > >> arm-init.c:(.text+0x64): undefined reference to `of_pci_range_parser_init' > > arm-init.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `of_pci_range_parser_init' > > >> arm-init.c:(.text+0x78): undefined reference to `of_pci_range_parser_one' > > arm-init.c:(.text+0x78): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `of_pci_range_parser_one' > > Ard, > > Not sure what's going on here. of_pci_range_parser_init() and > of_pci_range_parser_one() has a stub if CONFIG_OF_ADDRESS isn't > defined. So not sure why the bot is reporting "undefined symbol". > Thoughts? > You'll need a #ifdef CONFIG_PCI somewhere, I guess. > Also, thoughts on my patch? > Looks ok to me, but I haven't had a chance to test it yet.
