On Thu, 2 Jan 2020 at 16:51, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote: > > On Thu, Jan 02, 2020 at 04:20:46PM +0100, Ard Biesheuvel wrote: > > > > Yeah, good point. > > > > I pushed as branch here; > > https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=efi-libstub-attr-const > > > > Could you please check if that fixes the issue for efi_is_64bit() ? > > Haven't built it yet -- but how does this handle the GOT issues you > mentioned? It doesn't. The trick is to add __attribute__((visibility("hidden"))) to the extern declaration of efi_is64, but I am having trouble to reproduce the original issue.