On Tue, Dec 31, 2019 at 06:06:33PM +0100, Ard Biesheuvel wrote: > On Tue, 31 Dec 2019 at 17:51, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote: > > > > On Wed, Dec 18, 2019 at 07:01:36PM +0200, Ard Biesheuvel wrote: > > > Use 'func' as the macro parameter name for the efi_call() macros > > > which is less likely to collide and cause weird build errors. > > > > > > > For my education, what are the possible collisions/build errors that might happen? > > > > I was concerned about variables called 'f' being passed as one of the > arguments, but now that I think of it, I'm not sure how that could > break. > > In any case, I'd like to keep this patch since it also increases legibility. > No objections to the patch, I just wanted to check if I was missing something. Probably update the commit message though.