On Tue, 31 Dec 2019 at 01:26, niveditas98 . <nivedita@xxxxxxxxxxxx> wrote:
>
> Yeah I forgot to add comments for the second one before sending.
>
> For the first one I agree on the naming. If it looks sensible otherwise I can revise that.
>
Yes please
Also, could we use the argmaps to zero init the top half of OUT pointers? E.g.,
#define __efi64_argmap_allocate_pool(type, size, buffer) (type),
(size), efi_zi(buffer)
static inline void *efi_zi(void *p)
{
((u32 *)p)[1] = 0;
return p;
}
That would make the mixed mode support in the stub much more robust.
>
> ________________________________
> From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Sent: Monday, December 30, 2019 7:21 PM
> To: Arvind Sankar
> Cc: Ard Biesheuvel; linux-efi
> Subject: Re: [RFC PATCH 1/2] efi/x86: Check number of arguments to variadic functions
>
> On Mon, 30 Dec 2019 at 21:10, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote:
> >
> > This is on top of https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/?h=next
>
> Good stuff!
>
> I'd like to make a few tweaks, but this is definitely something I'd
> like to incorporate for v5.6
>
> The macros are a bit light on documentation, and I'd prefer to avoid
> macros recursively invoking C functions with the same name if we can.
