On Fri, 27 Dec 2019 at 23:44, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 25-12-2019 15:42, Ard Biesheuvel wrote: > > On Tue, 24 Dec 2019 at 20:34, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> Hi Ard, > >> > >> On 12/18/19 6:01 PM, Ard Biesheuvel wrote: > >>> The various pointers we stash in the efi_config struct which we > >>> retrieve using __efi_early() are simply copies of the ones in > >>> the EFI system table, which we have started accessing directly > >>> in the previous patch. So drop all the __efi_early() related > >>> plumbing, except for the access to a boolean which tells us > >>> whether the firmware is 64-bit or not. > >>> > >>> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > >> > >> I synced my personal tree yesterday to 5.5-rc3 + the most > >> recent version (as of yesterday afternoon) of your > >> efistub-x86-cleanup-v3 branch on top. > >> > >> This has been working fine on a bunch of devices, but it fails > >> on a Teclast X89 Bay Trail (mixed mode) device. When reverting all > >> the commits from your efistub-x86-cleanup-v3 branch one by one, things > >> start working again after reverting this one. > >> > > > > Oops again. And thanks again for taking the time to test this stuff. > > > > Could you please try the branch below and check whether it fixes it? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=efi-core-mm-fix > > This seems to fix the issue, the Teclast X89 boots again and I've > also tested this on 2 other devices (one mixed mode Bay Trail one 64 bit > Cherry Trail device). > Great, thanks. > If I want to also test them, how do the 2 new series you've just posted come > into the mix here? : > > "[PATCH 0/3] efi/x86: clean up and simplify runtime call wrappers" > "[PATCH 0/3] efi/x86: righten memory protections at runtime" > I have accumulated a couple of more fixes in addition, and a patch that I haven't sent out yet. Easiest to grab them from https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/?h=next -- Ard.
