On 12/03/19 20:40, Matthew Garrett wrote: > On Tue, Dec 3, 2019 at 3:54 AM Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > >> There is no reason this shouldn't apply to ARM, but disabling bus >> mastering like that before the drivers themselves get a chance to do >> so is likely to cause trouble. Network devices or storage controllers >> that are still running and have live descriptor rings in DMA memory >> shouldn't get the rug pulled from under their feet like that by >> blindly disabling the BM attribute on all root ports before their >> drivers have had the opportunity to do this cleanly. > > Yes, whether this causes problems is going to be influenced by the > behaviour of the hardware on the system. That's why I'm not defaulting > it to being enabled :) > >> One trick we implemented in EDK2 for memory encryption was to do the >> following (Laszlo, mind correcting me here if I am remembering this >> wrong?) >> - create an event X >> - register an AtExitBootServices event that signals event X in its handler >> - in the handler of event X, iterate over all PPBs to clear the bus >> master attribute >> - for bonus points, do the same for the PCIe devices themselves, >> because root ports are known to exist that entirely ignore the BM >> attribute >> >> This way, event X should get handled after all the drivers' EBS event >> handlers have been called. > > Can we guarantee that this happens before IOMMU state teardown? In OVMF, the handler of "event X" is in the IOMMU driver itself, so it's the IOMMU driver that takes care of blacklisting everything *after* other drivers had a chance to clean up. But in this case, we'd have to insert the PPB clearing *before* the (platform's) IOMMU driver's EBS handler (because the latter is going to deny, not permit, everything); and we can't modify the IOMMU driver. I guess we could install an EBS handler with TPL_NOTIFY (PciIo usage appears permitted at TPL_NOTIFY, from "Table 27. TPL Restrictions"). But: - if the IOMMU driver's EBS handler is also to be enqueued at TPL_NOTIFY, then the order will be unspecified - if a PCI driver sets up an EBS handler at TPL_CALLBACK, then in our handler we could shut down a PPB in front of a device bound by that driver too early. Handling dependencies between event notification functions is a never-ending struggle in UEFI, AFAICT. > I don't think there's a benefit to clearing the bit on endpoint devices, > if they're malicious they're just going to turn it back on anyway. > Thanks Laszlo
