On Fri, Jun 21, 2019 at 04:56:21PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag > values so that we can standardize the implementations that follow ext4's > flag values. I checked a few samples what's the type of the flags, there are unsigned types while the proposed VFS functions take signed type. > +int vfs_ioc_setflags_check(struct inode *inode, int oldflags, int flags); Specifically ext4 uses unsigned type and his was the original API that got copied so I'd think that it should unsigned everywhere. > fs/btrfs/ioctl.c | 13 +++++-------- For the btrfs bits Acked-by: David Sterba <dsterba@xxxxxxxx> and besides the signedness, the rest of the changes look good to me.
