On Fri, May 24, 2019 at 06:07:10PM +0200, Ard Biesheuvel wrote: > Apologies for only spotting this now, but I seem to have given some bad advice. > > efi_call_phys_prolog() in efi_64.c will also return NULL if > (!efi_enabled(EFI_OLD_MEMMAP)), but this is not an error condition. So > that occurrence has to be updated: please return efi_mm.pgd instead. Thanks for your reply, Ard. You mean that we should return efi_mm.pgd when allcoation fails? And we should delete return EFI_ABORTED on the caller site, right? In that case, how should we handle the NULL pointer returned by condition if(!efi_enabled(EFI_OLD_MEMMAP)) on the caller site? Thanks Gen