> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@xxxxxxxxxx] > Sent: Saturday, February 24, 2018 11:46 AM > To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx> > Cc: linux-efi@xxxxxxxxxxxxxxx; Linux Kernel Mailing List <linux- > kernel@xxxxxxxxxxxxxxx>; Borislav Petkov <bp@xxxxxxx>; the arch/x86 > maintainers <x86@xxxxxxxxxx> > Subject: Re: [PATCH 8/8] efi: Decode IA32/X64 Context Info structure > > On 23 February 2018 at 20:03, Yazen Ghannam > <Yazen.Ghannam@xxxxxxx> wrote: > > From: Yazen Ghannam <yazen.ghannam@xxxxxxx> > > > > Print the fields of the IA32/X64 Context Information structure. > > > > Print the "Register Array" as raw values. Some context types are defined > > in the UEFI spec, so more detailed decoded may be added in the future. > > > > Based on UEFI 2.7 section N.2.4.2.2 IA32/X64 Processor Context > > Information Structure. > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 4.16.x > > Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx> > > --- > > drivers/firmware/efi/cper-x86.c | 55 > +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper- > x86.c > > index 02b1b424f537..bb6cef0b5e53 100644 > > --- a/drivers/firmware/efi/cper-x86.c > > +++ b/drivers/firmware/efi/cper-x86.c > > @@ -13,6 +13,7 @@ > > #define VALID_LAPIC_ID BIT_ULL(0) > > #define VALID_CPUID_INFO BIT_ULL(1) > > #define VALID_PROC_ERR_INFO_NUM(bits) ((bits & GENMASK_ULL(7, 2)) > >> 2) > > +#define VALID_PROC_CNXT_INFO_NUM(bits) ((bits & GENMASK_ULL(13, > 8)) >> 8) > > Parens > > Also, CNXT isn't really idiomatic when abbreviating 'context' (and you > use CTX below as well) > The UEFI spec uses PROC_CONTEXT_INFO_NUM. Would you prefer 1 or 2 below? 1) VALID_PROC_CONTEXT_INFO_NUM 2) VALID_PROC_CTX_INFO_NUM Thanks, Yazen ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
