Currently on arm64 ESRT memory does not appear to be properly blocked off. Upon successful initialization, ESRT prints out the memory region that it exists in like: esrt: Reserving ESRT space from 0x000000000a4c1c18 to 0x000000000a4c1cf0. But then by dumping /proc/iomem this region appears as part of System RAM rather than being reserved: 08f10000-0deeffff : System RAM This causes issues when trying to kexec if the kernel is relocatable. When kexec tries to execute, this memory can be selected to relocate the kernel to which then overwrites all the ESRT information. Then when the kexec'd kernel tries to initialize ESRT, it doesn't recognize the ESRT version number and just returns from efi_esrt_init(). This causes an early ioremap leak because the memory allocated for 'va' is never unmapped. So first fix that error case to properly unmap 'va' before returning. This still leaves ESRT unable to initialize in the kexec'd kernel, so now mark the ESRT memory block as nomap so that this memory is not treated as System RAM. With this change I'm able to see that the ESRT data is not overwritten when running a kexec'd kernel. Tyler Baicar (2): efi/esrt: fix unsupported version initialization failure efi/esrt: mark ESRT memory region as nomap drivers/firmware/efi/esrt.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
