On 26 January 2018 at 21:16, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 18 Jan, at 01:01:04PM, Sai Praneeth Prakhya wrote: >> From: Sai Praneeth <sai.praneeth.prakhya@xxxxxxxxx> >> >> Presently, in x86, to invoke any efi function like >> efi_set_virtual_address_map() or any efi_runtime_service() the code path >> typically involves read_cr3() (save previous pgd), write_cr3() >> (write efi_pgd) and calling efi function. Likewise after returning from >> efi function the code path typically involves read_cr3() (save efi_pgd), >> write_cr3() (write previous pgd). We do this couple of times in efi >> subsystem of Linux kernel, instead we can use helper function >> efi_switch_mm() to do this. This improves readability and maintainability. >> Also, instead of maintaining a separate struct "efi_scratch" to store/restore >> efi_pgd, we can use mm_struct to do this. > > FWIW this series looks OK to me. > > Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> Thanks Matt I know the x86 guys have been rather busy lately, so I will give them some more time to respond. If there are no objections raised, I will queue it for v4.17 in a couple of weeks. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
