Re: [PATCH] efi: Clarify that reset attack mitigation needs appropriate userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8 January 2018 at 22:50, Matthew Garrett <mjg59@xxxxxxxxxx> wrote:
> Some distributions have turned on the reset attack mitigation feature,
> which is designed to force the platform to clear the contents of RAM if
> the machine is shut down uncleanly. However, in order for the platform
> to be able to determine whether the shutdown was clean or not, userspace
> has to be configured to clear the MemoryOverwriteRequest flag on
> shutdown - otherwise the firmware will end up clearing RAM on every
> reboot, which is unnecessarily time consuming. Add some additional
> clarity to the kconfig text to reduce the risk of systems being
> configured this way.
>
> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxx>
> Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Cc: linux-efi@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx

Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

Ingo, do you mind picking this up directly?

https://marc.info/?l=linux-efi&m=151545181706115

> ---
>  drivers/firmware/efi/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 2b4c39fdfa91..86210f75d233 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -159,7 +159,10 @@ config RESET_ATTACK_MITIGATION
>           using the TCG Platform Reset Attack Mitigation specification. This
>           protects against an attacker forcibly rebooting the system while it
>           still contains secrets in RAM, booting another OS and extracting the
> -         secrets.
> +         secrets. This should only be enabled when userland is configured to
> +         clear the MemoryOverwriteRequest flag on clean shutdown after secrets
> +         have been evicted, since otherwise it will trigger even on clean
> +         reboots.
>
>  endmenu
>
> --
> 2.16.0.rc0.223.g4a4ac83678-goog
>
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux