Ard, sorry for the delayed response. Working on HXT ARM Server Reference Evaluation Platform based on 4.15.0-rc5 Tested-by: Ge Song <ge.song@xxxxxxxxxxxxxxxx> ________________________________________ From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> Sent: Saturday, December 30, 2017 12:35 AM To: Bryan O'Donoghue Cc: linux-efi@xxxxxxxxxxxxxxx; Matt Fleming; Jan Kiszka; Richard Ruigrok; Song, Ge Subject: Re: [RFT PATCH] efi: capsule-loader: reinstate virtual capsule mapping On 29 December 2017 at 03:09, Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> wrote: > >> So we need to fix this without breaking Quark. Fortunately, Quark does >> not appear to care about the virtual mapping, and so we can simply >> do a partial revert of commit 2a457fb31df6 ("efi/capsule-loader: Use >> page addresses rather than struct page pointers"), and create a vmap() >> mapping of the entire capsule (including header) based on the reinstated >> struct page array, unless running on Quark, in which case we pass the >> capsule header copy as before. > > > > Working on the Galileo (Quark x1000 non-secure) Ard. I've tested a capsule > with and without the quirk header so it should work on the secure part too. > > Tested-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> > Thanks Bryan Ge, Richard, any feedback? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html