On Mon, Dec 04, 2017 at 10:02:16AM +0800, Dave Young wrote: > +#define __ATTR_IRUSR(_name) { \ > + .attr = { .name = __stringify(_name), .mode = S_IRUSR }, \ > + .show = _name##_show, \ > +} Ick, no, as others, including Linus, have said, using IRUSER is a pain in the ass to try to look up and remember what it is... Just use __ATTR() please, it should be fine for what you need to do, which is special-case a sysfs attribute. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html