On Thu, Nov 30, 2017 at 12:10 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> So changing it to use __ATTR() should fix this remaning leakage up.
> That is if we even really need to export these values at all. What does
> userspace do with them? Shouldn't they just be in debugfs instead?
So what I find distasteful here is how sysfs has these "helper" macros
that are clearly designed to over-share.
The __ATTR macro is a lot more complicated to use than the
__ATTR_RO/WO/RW macros, but those macros end up giving everybody read
access (ok, not the WO one)
So honestly, I think the "helper" functions should be deprecated
simply because they basically encourage people to make everything
world-readable.
Which is why most of sysfs is world-readable, whether it makes sense or not.
It would have been better had they just taken the actual mode, I suspect.
(And it would be better yet if the code didn't use that disgusting
S_IRUGO, which pretty much everybody has to think about to figure out
it's 0444)
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
