> From: Ard Biesheuvel [mailto:ard.biesheuvel@xxxxxxxxxx] > >> It looks like that my test BIOS on Intel Kabylake board interprets it *pointer" and pack the array, so my patch can work on that board. > > Are you running 64-bit firmware on this board? Because the EDK2 side lacks the 'packed' attribute, which means there is 4 bytes of padding after the first member of EFI_CAPSULE_TABLE. Yes, I was running 64-bit firmware on this board. I confirmed with the BIOS engineer that this firmware had already included the " #pragma pack(1)" attribute for 1 byte alignment. > Ah yes, I missed that bit before. So yes, it probably makes most sense to keep your definition, and update the EDK2 side so it works on 64-bit as well. Hope so. > I hope we can settle this by the end of this week, and if the clarification aligns with your definition, I will queue the patches as they are. OK, Thanks! :-) ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
