On 2017-03-24 21:39, Andy Shevchenko wrote: > On Fri, Mar 24, 2017 at 7:34 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote: >> This addresses the review feedback provided on round 1, specifically >> - refactored queue to keep the Quark mess in >> - only check for CSH on Quark CPUs >> - added some smaller cleanups of the capsule loader >> - documented capsule header / linked to original code >> >> See last patch for the background of the series. >> >> The series has been tested on the Galileo Gen2, to exclude regressions, >> with a firmware.cap with AND without security header and the SIMATIC >> IOT2040 which requires the header because of its mandatory secure boot. > > The series looks good to me from code prospective. It's clean and > understandable, though I have couple of comments (see related > patches). > Please, address them. Done, also the kbuild reboot finding and another build issue along that. Will send v3 after testing again (unfortunately not on the Galileo - my board died). > > I wasn't able to test it, thus FWIW: > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
