On Wed, Nov 23, 2016 at 09:53:00AM +0000, David Howells wrote: > Lukas Wunner <lukas@xxxxxxxxx> wrote: > > It just occurred to me that the boot_params struct is populated in > > make_boot_params(), perhaps it makes sense to move this line there. > > Otherwise LGTM. > > Ummm... Looking at arch/x86/boot/compressed/head_64.S, make_boot_params() is > only called if the stub is entered through efi_pe_entry, not if entered > through efi64_stub_entry, whereas efi_main() is called in both cases. I think > entry through efi32_stub_entry may also skip make_boot_params(). > > The comment on make_boot_params() suggests that this function is only used if > whoever booted the kernel didn't supply it. Good point. :-) I didn't dig this deep, it was just something that crossed my mind when skimming over the patch. You're also right about the (efi_##f##_t *) addition in patch 2. Thanks, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
