(+ Linn) On 21 November 2016 at 11:42, David Howells <dhowells@xxxxxxxxxx> wrote: > Hi Lukas, > > Looking in efi_get_secureboot(), is there a reason: > > efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID; > > isn't static const? > Not a good one, no. It used to be static const, but for some reason, commit 30d7bf034c03 ("efi/arm64: Check SetupMode when determining Secure Boot status") removed the static and the const (and I reviewed it and did not complain AFAIR) I'll gladly take a patch that reinstates that, though. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html