* Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote:
> >
> > * Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> > >
> > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and
> > > install the Linux-specific RNG seed UEFI config table. This will be
> > > picked up by the EFI routines in the core kernel to seed the kernel
> > > entropy pool.
> > >
> > > Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> >
> > This commit (and the commits after this one) doesn't have a proper signoff chain,
> > probably due to rebasing?
>
> Argh, my bad. This is fallout from moving to the co-maintainer model.
> My scripts assume they don't need to append a SoB because that was
> handled when applying the patch to the git tree.
>
> But that obviously doesn't hold if Ard applies the patch to git, but I
> mail out the patches as part of the pull request (or vice versa).
>
> I guess in future you'd wanna see the SoB of the person mailing the
> patches, right?
The problem is not that Ard applied the patches, but that you subsequently rebased
the tree. For example:
commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4
Author: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
AuthorDate: Thu Oct 20 12:21:26 2016 +0100
Commit: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
CommitDate: Sat Nov 12 21:14:41 2016 +0000
efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table
Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and
install the Linux-specific RNG seed UEFI config table. This will be
picked up by the EFI routines in the core kernel to seed the kernel
entropy pool.
Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
if you rebase it (with your co-maintainer's permission) then you need to add your
SoB tag.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
