Re: [PATCH 1/3] efi/efi_test: use memdup_user() as a cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2016年10月05日 05:37, Matt Fleming wrote:
On Tue, 04 Oct, at 11:04:56AM, ivanhu wrote:
Hi Matt,

The warning message is from Kbuild test robot,

https://chromium.googlesource.com/linux-fpga-chameleon/+/fpga-chameleon-4.2/scripts/coccinelle/api/memdup_user.cocci,


and  I believe it tries to persuade us to use memdup_user instead of kmalloc
and copy_form_user,

With this new function, we don't have to write 'len' twice, which can lead
to typos/mistakes.
It also produces smaller code and kernel text.

http://lkml.iu.edu/hypermail/linux/kernel/0903.0/02349.html

Right, I understand all that. My question was specifically about the
following sentence from your patch,

This is a little bit restricted to reduce false positives

What restriction that reduces false positives are you referring to?

I believe that author means that, with this new function, we don't have to write 'len' twice, which can lead to typos/mistakes ....

Let me remove the ambiguous comments and send out the patch again.

Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux