On 2016/9/13 19:18, Matt Fleming wrote: > On Wed, 07 Sep, at 07:15:48PM, Yisheng Xie wrote: >> >> >> On 2016/9/5 21:57, Matt Fleming wrote: >>> On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote: >>>> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote: >>>>> From: Yisheng Xie <xieyisheng1@xxxxxxxxxx> >>>>> >>> >>> This should be a call to efi_memmap_unmap() because the EFI_MEMMAP >>> flag also needs clearing. >>> >> Hi Matt, >> Thanks for your reply. >> You mean call the function efi_unmap_memmap() like x86? >> >> however, it seems no need to clear EFI_MEMMAP here. For arm*, the flag >> EFI_MEMMAP is set in function reserve_regions(), which is called >> only when uefi_init() return 0: >> >> efi_init() >> -> reserve_regions() >> -> set_bit(EFI_MEMMAP, &efi.flags); > > This patch should be against the 'next' branch here, > > https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/log/?h=next > > My comments were made with that branch in mind. > Hi Matt, Sorry for my misunderstanding, I will try to rebase to next branch. Thanks. Yisheng Xie. > . > -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html