On Wed, 27 Jul, at 01:21:17PM, Jeffrey Hugo wrote: > On 7/27/2016 12:03 PM, Matt Fleming wrote: > > > >Why not move the priv_func call until after we know ExitBootServices() > >returned successfully? That way we don't have to make two calls and > >the callee doesn't need to handle that. > > > > It keeps the code flow for FDT (patch 3 in the series) and x86 (patch 4) the > same as before, and x86 seems to require that its function occurs before > ExitBootServices(). > > exit_boot() calls alloc_e820ext() based on the contents of the current > memory map, which invokes allocate_pool(). Per my understanding of the > spec, allocate_pool() should not be called after ExitBootServices(), and per > my understanding of the x86 code, alloc_e820ext() needs to be called between > getting the current memory map, and ExitBootServices(). Am I incorrect, and > there is an option to restructure the x86 code so that this ordering is not > required? On second thoughts, it's fine as-is. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
