On Mon, 18 Apr, at 03:05:42PM, Jeremy Compostella wrote:
> +static void efibc_set_variable(const char *name, const char *value)
> +{
> + int ret;
> + efi_guid_t guid = EFI_LOADER_GUID;
> + struct efivar_entry entry;
> + size_t size = (strlen(value) + 1) * sizeof(efi_char16_t);
Putting 'entry' on the stack leads to the following build warning,
drivers/firmware/efi/efibc.c: In function ‘efibc_set_variable’:
drivers/firmware/efi/efibc.c:53:1: warning: the frame size of 2192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
That's a big object.
Given that efibc_reboot_notifier_call() can only be invoked once,
could we just statically allocate 'entry' instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
