--- Robert Elliott, HPE Persistent Memory > -----Original Message----- > From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel- > owner@xxxxxxxxxxxxxxx] On Behalf Of Matt Fleming > Sent: Monday, December 21, 2015 10:06 AM > To: Elliott, Robert (Persistent Memory) <elliott@xxxxxxx> > Cc: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; x86@xxxxxxxxxx; > linux-efi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4] x86/efi: show actual ending addresses in > efi_print_memmap > > On Mon, 21 Dec, at 03:50:38PM, Matt Fleming wrote: > > On Thu, 17 Dec, at 07:28:31PM, Robert Elliott wrote: > > > Adjust efi_print_memmap to print the real end address of each > > > range, not 1 byte beyond. This matches other prints like those for > > > SRAT and nosave memory. > > > > > > Change the closing ) to ] to match the opening [. > > > > > > old: > > > efi: mem61: [Persistent Memory | | | | | | | > |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c80000000) (16384MB) > > > > > > new: > > > efi: mem61: [Persistent Memory | | | | | | | > |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16384MB) > > > > > > Example other address range prints: > > > SRAT: Node 1 PXM 1 [mem 0x480000000-0x87fffffff] > > > PM: Registered nosave memory: [mem 0x880000000-0xc7fffffff] > > > > > > Signed-off-by: Robert Elliott <elliott@xxxxxxx> > > > --- > > > arch/x86/platform/efi/efi.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Is this change purely for aesthetic reasons? We're usually not in the > > habit of changing the output of print messages without a good reason > > because people downstream do rely on them being consistent. > > I just noticed the bracket change. > > My comment above only refers to printing the range addresses. Swapping > ')' for ']' is a perfectly valid change. While investigating the grub persistent memory corruption issues, it was helpful to make this table match the ending address convention used by: * the kernel's e820 table prints * the kernel's nosave memory prints * grub's lsmmap and lsefimmap commands * the UEFI shell's memmap command Using the excerpts from the patch, if you grep all the various logs for c7fffffff, you won't find the line with c80000000. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
