On Mon, 2015-12-21 at 18:37 +0100, Borislav Petkov wrote: > On Mon, Dec 21, 2015 at 05:04:11PM +0000, Bryan O'Donoghue wrote: > > > This patch also export efi_capsule_supported() function symbol > > > for > > > verifying the submitted capsule header in this kernel module. > > > > 1. Should be a separate patch > > 2. Suggested, rewording for that patch log > > > > 2/2 Title > > This patch exports efi_capsule_supported to enable verification of > > the > > capsule header. > > > > That said - who is the user of this symbol ? Why is it needed ? > > Anyway > > please consider splitting and rewording. > > Huh? > > I still don't really see the reasoning for splitting out the export. > > When you do the export and use it in a single patch it is *obvious* > why > it is being exported. > > And there's no need to mention in the commit message that you're > exporting a symbol. People export symbols all the time. > Yes - saw the export down the end of the patchset. Feel free to ignore that comment. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
