On Thu, Nov 12, 2015 at 03:40:18PM +0000, Matt Fleming wrote: > The x86 pageattr code is confused about the data that is stored > cpa->pfn, sometimes it's treated as a page fram number and sometimes > it's treated as an unshifted physical address. > > The result of this is that the mapping functions do not map the > intended physical address. > > This isn't a problem in practice because most of the addresses we're > mapping in the EFI code paths are already mapped in 'trampoline_pgd' > and so the pageattr mappings functions don't actually do anything in > this case. But when we move to using a separate page table for the EFI > runtime this will be an issue. > > Cc: Borislav Petkov <bp@xxxxxxxxx> > Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@xxxxxxxxx> > Cc: Dave Hansen <dave.hansen@xxxxxxxxx> > Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> > --- > arch/x86/mm/pageattr.c | 12 ++++++------ > arch/x86/platform/efi/efi_64.c | 33 ++++++++++++++++++++++----------- > 2 files changed, 28 insertions(+), 17 deletions(-) Reviewed-by: Borislav Petkov <bp@xxxxxxx> -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html