On 28 October 2015 at 11:10, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote: > Ard Biesheuvel wrote: >> >> + *image_addr = *reserve_addr = round_up(dram_base, SZ_2M) + >> + TEXT_OFFSET); > > > Shouldn't this be: > > *image_addr = *reserve_addr = round_up(dram_base + TEXT_OFFSET, SZ_2M); > No. I screwed up the patch since the trailing ) should not be there, but we do need to round first, and only then add the offset. -- Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html