On 10 October 2015 at 22:53, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 01 Oct, at 07:04:15PM, Ard Biesheuvel wrote: >> This splits off the early EFI init and runtime code that >> - discovers the EFI params and the memory map from the FDT, and installs >> the memblocks and config tables. >> - prepares and installs the EFI page tables so that UEFI Runtime Services >> can be invoked at the virtual address installed by the stub. >> >> This will allow it to be reused for 32-bit ARM. >> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> --- >> arch/arm64/kernel/efi.c | 363 +------------------- >> drivers/firmware/efi/Makefile | 4 +- >> drivers/firmware/efi/arm-init.c | 214 ++++++++++++ >> drivers/firmware/efi/arm-runtime.c | 191 ++++++++++ >> 4 files changed, 409 insertions(+), 363 deletions(-) > > [...] > >> +static int uefi_debug __initdata; >> +static int __init uefi_debug_setup(char *str) >> +{ >> + uefi_debug = 1; >> + >> + return 0; >> +} >> +early_param("uefi_debug", uefi_debug_setup); > > Was this hunk an unintentional reintroduction of the code Leif deleted > in commit a9cc0cf5701b ("arm64: Use core efi=debug instead of > uefi_debug command line parameter")? > Indeed. I will get rid of it on v2 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html