On 05/10/15 16:19, Kweh, Hock Leong wrote:
-----Original Message-----
From: Borislav Petkov [mailto:bp@xxxxxxxxx]
Sent: Monday, October 05, 2015 9:14 PM
So this one is still a separate patch.
If you're going to ignore review comments, maybe I should stop wasting my
time reviewing your stuff...
--
Regards/Gruss,
Boris.
Already follow what you have suggested, put a note under --- line:
https://lkml.org/lkml/2015/10/5/230 (at line 25 - 27)
Thanks for the review comments.
Wilson - trying to test this out on a Galileo Gen2 - which branch are
you doing this against ?
I can apply the first patch you're proposing to squash your commit into
https://lkml.org/lkml/diff/2014/10/7/390/1
but then trying to apply the first in your series on top of that patch I get
deckard@aineko:~/Development/linux$ git apply
../patches/capsule_wilson/1_2.eml
../patches/capsule_wilson/1_2.eml:72: trailing whitespace.
EXPORT_SYMBOL_GPL(efi_capsule_supported);
error: drivers/firmware/efi/capsule.c: No such file or directory
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule/drivers/firmware/efi/capsule.c
??
If so - then why not use the interface here ?
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule
(Sorry I know I'm coming to this thread late)
Aside from that, I'm curious which types of capsules you've used here
too - does it include the MFH header ? Keep in mind the initial firmware
that shipped with Galileo will depend on that MFH being present.
http://download.intel.com/support/processors/quark/sb/quark_securebootprm_330234_001.pdf
- Section A1 - table 7 ?
So if we boot a 4.x kernel with that initial firmware version 0.75 if
memory serves - it's important that the capsule.c code handles the MFH.
--
BOD
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
