On Wed, Aug 26, 2015 at 06:11:28PM +0100, Matt Fleming wrote: > On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote: > > The Kconfig for this driver is currently hidden with: > > > > config EFI_ESRT > > bool > > > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > > > Since module_init translates to device_initcall in the non-modular > > case, the init ordering remains unchanged with this commit. > > > > We leave some tags like MODULE_AUTHOR for documentation purposes. > > > > We don't replace module.h with init.h since the file already has that. > > > > Cc: Matt Fleming <matt.fleming@xxxxxxxxx> > > Cc: Peter Jones <pjones@xxxxxxxxxx> > > Cc: linux-efi@xxxxxxxxxxxxxxx > > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > > Looks good to me. I know Peter is on vacation right now, so I'm still > expecting a response from him. In the meantime, I'll queue this up in > the EFI 'next' branch. Thanks! Looks fine to me as well. -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html