On Fri 2015-07-31 18:52:09, joeyli wrote: > On Tue, Jul 28, 2015 at 02:21:33PM +0200, Pavel Machek wrote: > > Hi! > > > > > int cmdline_find_option_bool(const char *option); > > > #endif > > > > > > +#if CONFIG_RANDOMIZE_BASE > > > > Not ifdef? > > > > > +extern u16 i8254(void); > > > > That's rather poor name for global function... > > This i8254 function only used by aslr and efi_random. > I will keep this name for do not change codes in aslr for naming. No. That's not suitable function name for global function. And you are making it global. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html