[snip]
> > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> > > index cfba30f..d323e3a 100644
> > > --- a/arch/x86/platform/efi/efi.c
> > > +++ b/arch/x86/platform/efi/efi.c
> > > @@ -972,6 +972,10 @@ u64 efi_mem_attributes(unsigned long phys_addr)
> > >
> > > static int __init arch_parse_efi_cmdline(char *str)
> > > {
> > > + if (!str) {
> > > + pr_warn("need at least one option\n");
I feel pr_warn is too much for an invalid param, what if other invalid
case then? IMHO returning an error code is enough.
Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
