Matt/Ricardo, thanks for ccing me, and sorry for late response I thought to reply but I was busy on other things.. On 07/01/15 at 10:37am, Ricardo Neri wrote: > On Wed, 2015-07-01 at 14:19 +0100, Matt Fleming wrote: > > Did you hit this by passing "efi=" on the kernel command line? > > I hit this by passing "efi" alone. "efi=" works well because the pointer > points to a valid string that only contains \0. > > > > I would have assumed that the generic early param parsing code would > > have caught this problem since it's obviously a potential issue for > > every other early_param() function, and so needs to be solved in a > > more > > general way. > > Yes, I was dubious on where to apply the patch. I saw that > parse_option_str does not check for the validity of the pointers. That > might seem to be a more general fix. I'll take that route. Ricardo, I agree to fix it in parse_option_str. Do you have sent any update ? Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html