On 09/06/2015 at 11:15:35 +0200, Ard Biesheuvel wrote : > The rtc-efi driver declares that the EFI 'epoch' is 1/1/1998, but > the UEFI spec does not define it at all. It does define a range of > [1900, 9999] for the 'Year' member of the EFI_TIME struct, so let's > use 1900 as the minimum year and not 1998. > Also, move the validation of the year to the convert_from_efi_time() > routine where all other EFI_TIME fields are validated as well. > > This prevents rtc_read_time() failures when the RTC that backs the > EFI time services is set to a date before 1998, e.g., when it has > lost power. > > This also optimizes the compute_wday() routine, by replacing the for > loop with a simple arithmetic expression, and by reusing the yearday > value that we need to compute anyway when populating the > rtc_time::tm_yday field. > > Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > Cc: rtc-linux@xxxxxxxxxxxxxxxx > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
