On 30 April 2015 at 18:04, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 30 Apr, at 03:23:05PM, Jean Delvare wrote: >> The SMBIOS3 table should appear before the SMBIOS table in >> /sys/firmware/efi/systab. This allows user-space utilities which >> support both to pick the SMBIOS3 table with a single pass on systems >> where both are implemented. The SMBIOS3 entry point is more capable >> than the SMBIOS entry point so it should be preferred. >> >> This follows the same logic as the ACPI20 table being listed before >> the ACPI table. >> >> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> >> Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> Cc: Leif Lindholm <leif.lindholm@xxxxxxxxxx> >> Cc: Matt Fleming <matt.fleming@xxxxxxxxx> >> --- >> Changes since v1: >> * Added a comment explaining why SMBIOS3 must be listed before SMBIOS, >> so that it doesn't get accidentally broken in the future. >> >> drivers/firmware/efi/efi.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) > > Thanks Jean. This looks OK to me but I'd really like to see some ACKs > from Leif, Ard or Ivan. > I don't have any objections to this patch per se, but I am not crazy about the fact that the way the output is ordered is kernel<->userland ABI now But since there appears to be a precedent with ACPI20 before ACPI, that was already the case, apparently. So, Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
