On Sat, Mar 07, 2015 at 05:59:14PM -0800, David Rientjes wrote: > On Sat, 7 Mar 2015, Yinghai Lu wrote: > > > Now we are using memblock to do early resource reserver/allocation > > instead of using e820 map directly, and setup_data is reserved in > > memblock early already. > > Also kexec generate setup_data and pass pointer to second kernel, > > so second kernel reserve setup_data by their own. > > (Now kexec-tools create SETUP_EFI and SETUP_E820_EXT). > > > > We can kill E820_RESERVED_KERN and not touch e820 map at all. > > > > That will fix bug in mark_nonsave_region that can not handle that > > case: E820_RAM and E820_RESERVED_KERN ranges are continuous and > > boundary is not page aligned. > > > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=913885 > > Is this the bug referenced in the commit message that is fixed? If so, > it's only a bug for resume, correct? I'm not sure if that's clear enough > just from the commit message, I was looking at this patch for an e820 > problem I'm currently facing on 3.3. Yinghai's patches fixed the e820 not page aligned issue that's one of the issues on bug reporter's machine. I found another issue of the BIOS that sometimes it doesn't really keep the e820 table unchanging for hibernate resuming, this BIOS issue causes the total available page number checking fail. I will file another openSUSE bug to separate those 2 issues. > > > Reported-by: "Lee, Chun-Yi" <jlee@xxxxxxxx> > > Tested-by: "Lee, Chun-Yi" <jlee@xxxxxxxx> > > Cc: "Lee, Chun-Yi" <jlee@xxxxxxxx> > > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > Hmm, although the bug is reported for a 3.12 kernel, I assume this is for > stable 3.10+? If so, it should apply fine with the exception of removing > e820_reserve_setup_data() from setup_arch() rather than > memblock_x86_reserve_range_setup_data(). Or is it for 3.2 as well and > needs to be completely rebased for that kernel? Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
