On Nov 6, 2014 4:56 AM, "Kweh, Hock Leong" <hock.leong.kweh@xxxxxxxxx> wrote: > > > -----Original Message----- > > From: Andy Lutomirski [mailto:luto@xxxxxxxxxxxxxx] > > Sent: Wednesday, November 05, 2014 12:36 AM > > > > Am I missing something here? The current proposal is missing the > > success/failure part, unless you count the loaded count (in a different sysfs > > directory) as a useful interface for that. > > Here is my sample shell script which allow me to do multi capsule binaries upload > and obtain error message if error occur: > > #!/bin/sh > > old=$(cat /sys/devices/platform/efi_capsule_user_helper/capsule_loaded) > > for arg in "$@" > do > if [ -f $arg ] > then > echo 1 > /sys/class/firmware/efi-capsule-file/loading > cat $arg > /sys/class/firmware/efi-capsule-file/data > echo 0 > /sys/class/firmware/efi-capsule-file/loading I think you have a race. Try putting msleep(1000) after the request_firmware_nowait call, and I bet this will fail on the second try. > > oldtime=$(date +%S) > oldtime=$(((time + 2) % 60)) > until [ -f /sys/class/firmware/efi-capsule-file/loading ] > do > newtime=$(date +%S) > if [ $newtime -eq $oldtime ] > then > break > fi > done > > old=$((old + 1)) > new=$(cat /sys/devices/platform/efi_capsule_user_helper/capsule_loaded) I think that firmware_class doesn't call the callback until after loading is closed for the second time. If so, then this is racy. Try inserting msleep(1000) at the beginning of your callback and uploading a capsule that should load successfully -- this will report failure, but a future upload may get very confused. Also, what does the firmware class do when simultaneous uploads of the same file with different contents are in flight? Is that possible? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
