On Wed, Oct 22, 2014 at 03:21:53PM +0100, Ard Biesheuvel wrote: > This sets the DMI string, containing system type, serial number, > firmware version etc. as dump stack arch description, so that oopses > and other kernel stack dumps automatically have this information > included, if available. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > --- > arch/arm64/kernel/efi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c > index 0e9da0067ef2..baab9344a32b 100644 > --- a/arch/arm64/kernel/efi.c > +++ b/arch/arm64/kernel/efi.c > @@ -477,6 +477,8 @@ static int __init arm64_dmi_init(void) > * itself, depends on dmi_scan_machine() having been called already. > */ > dmi_scan_machine(); > + if (dmi_available) > + dmi_set_dump_stack_arch_desc(); This looks fine, but I don't understand why you would ever *not* want to call this when DMI is available. In other words, why can't this be part of dmi_scan_machine? Will -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html