On Wed, 10 Sep, at 01:00:22AM, Andre wrote:
> All other calls to allocate memory seem to make some noise already, with the
> exception of two calls (for gop, uga) in the setup_graphics path.
>
> The purpose is to be noisy on worrysome errors immediately.
>
> > commit fb86b2440de0ec10fe0272eb19d262ae7a01adb8
> > Author: Ulf Winkelvos <ulf@xxxxxxxxxxxx>
> > Date: Thu Jul 10 02:12:41 2014 +0200
> >
> > x86/efi: Add better error logging to EFI boot stub
>
> introduces printing false alarms for lots of hardware. Rather than playing
> Whack a Mole with non-fatal exit conditions, try the other way round.
The usual way to reference existing commits is to quote the commit sha1
(abbreviated to 12-characters) with the patch subject in parenthesis and
quotes, i.e. commit fb86b2440de0 ("x86/efi: Add better error logging to
EFI boot stub") - I fixed this up.
> This is per Matt Fleming's suggestion:
>
> > Where I think we could improve things
> > is by adding efi_printk() message in certain error paths. Clearly, not
> > all error paths need such messages, e.g. the EFI_INVALID_PARAMETER path
> > you highlighted above, but it makes sense for memory allocation and PCI
> > read failures.
>
> http://article.gmane.org/gmane.linux.kernel.efi/4628
>
> After this, the status check on the setup_efi_pci() function
> can go away again.
>
> Signed-off-by: Andre Müller <andre.muller@xxxxxx>
> ---
> arch/x86/boot/compressed/eboot.c | 29 ++++++++++++++++++++++-------
> 1 file changed, 22 insertions(+), 7 deletions(-)
Patch looks good to me. Applied, thanks!
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
