Re: [PATCH] x86/efi: autoload efivars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-07-08 at 11:14 +0100, Matt Fleming wrote:
> On Tue, 08 Jul, at 11:00:58AM, Lee, Chun-Yi wrote:
[...]
> > --- a/arch/x86/platform/efi/efi.c
> > +++ b/arch/x86/platform/efi/efi.c
> > @@ -44,6 +44,7 @@
> >  #include <linux/io.h>
> >  #include <linux/reboot.h>
> >  #include <linux/bcd.h>
> > +#include <linux/platform_device.h>
> >  
> >  #include <asm/setup.h>
> >  #include <asm/efi.h>
> > @@ -780,6 +781,20 @@ void __init efi_late_init(void)
> >  	efi_bgrt_init();
> >  }
> >  
> > +#ifdef CONFIG_EFI_VARS_MODULE
> > +static int __init efi_load_efivars(void)
> > +{
> > +	struct platform_device *pdev;
> > +
> > +	if (!efi_enabled(EFI_RUNTIME_SERVICES))
> > +		return 0;
> > +
> > +	pdev = platform_device_register_simple("efivars", 0, NULL, 0);
> > +	return IS_ERR(pdev) ? PTR_ERR(pdev) : 0;
> > +}
> > +device_initcall(efi_load_efivars);
> > +#endif
> > +
> 
> Could this be moved to drivers/firmware/efi/efi.c? That way the arm64
> folks could benefit from it too.

It seems like that should work now that efi_enabled() is not specific to
x86.

Ben.

> >  void __init efi_set_executable(efi_memory_desc_t *md, bool executable)
> >  {
> >  	u64 addr, npages;
> > diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
> > index 463c565..f256ecd 100644
> > --- a/drivers/firmware/efi/efivars.c
> > +++ b/drivers/firmware/efi/efivars.c
> > @@ -78,6 +78,7 @@ MODULE_AUTHOR("Matt Domsch <Matt_Domsch@xxxxxxxx>");
> >  MODULE_DESCRIPTION("sysfs interface to EFI Variables");
> >  MODULE_LICENSE("GPL");
> >  MODULE_VERSION(EFIVARS_VERSION);
> > +MODULE_ALIAS("platform:efivars");
> >  
> >  LIST_HEAD(efivar_sysfs_list);
> >  EXPORT_SYMBOL_GPL(efivar_sysfs_list);
> > -- 
> > 1.8.4.5
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Ben Hutchings
Any smoothly functioning technology is indistinguishable from a rigged demo.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux