Re: [PATCH v3 1/5] efi/arm64: Avoid EFI_ERROR as a generic return code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 2, 2014 at 5:54 AM, Ard Biesheuvel
<ard.biesheuvel@xxxxxxxxxx> wrote:
> As EFI_ERROR is not a UEFI result code but a local invention only
> intended to allow get_dram_base() to signal failure, we should not use
> it elsewhere.
>
> Replace with EFI_LOAD_ERROR.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> ---
>  arch/arm64/kernel/efi-stub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/efi-stub.c b/arch/arm64/kernel/efi-stub.c
> index e786e6cdc400..7aa7155a9740 100644
> --- a/arch/arm64/kernel/efi-stub.c
> +++ b/arch/arm64/kernel/efi-stub.c
> @@ -69,7 +69,7 @@ static efi_status_t handle_kernel_image(efi_system_table_t *sys_table,
>                 if (*image_addr != (dram_base + TEXT_OFFSET)) {
>                         pr_efi_err(sys_table, "Failed to alloc kernel memory\n");
>                         efi_free(sys_table, kernel_memsize, *image_addr);
> -                       return EFI_ERROR;
> +                       return EFI_LOAD_ERROR;
>                 }
>                 *image_size = kernel_memsize;
>         }
> --
> 1.8.3.2
>

Looks good.

Acked-by: Roy Franz <roy.franz@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux