Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18 June 2014 11:02, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
> On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote:
>> Fix two instances of pointer type errors, a harmless one where a const void*
>> value is assigned to a non-const void* variable, and a not-so-harmless one where
>> we pass a pointer to unsigned long where a pointer to int is expected.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>> ---
>>  drivers/firmware/efi/efi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
>> index cd36deb619fa..fe737832a882 100644
>> --- a/drivers/firmware/efi/efi.c
>> +++ b/drivers/firmware/efi/efi.c
>> @@ -353,8 +353,8 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
>>                                      int depth, void *data)
>>  {
>>       struct param_info *info = data;
>> -     void *prop, *dest;
>> -     unsigned long len;
>> +     void const *prop, *dest;
>> +     int len;
>>       u64 val;
>>       int i;
>
> const void *?
>

You say potato, I say po-tah-to?
But seriously, whichever you prefer ...

Regards,
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux